Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change language needs require restart text similar to other pref settings #6782

Closed
srirambv opened this issue Jan 20, 2017 · 1 comment
Closed

Change language needs require restart text similar to other pref settings #6782

srirambv opened this issue Jan 20, 2017 · 1 comment
Labels
bug/good-first-bug copy/content/text QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings
Milestone
0.13.2

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 20, 2017 •
edited
Loading

  • Did you search for similar issues before submitting this one?

  • Describe the issue you encountered:
    Change language needs require (requires browser restart)similar to other pref settings

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev fefd17c

  • Steps to reproduce:

    1. Do a clean install of 0.13.0
    2. Open preferences page
    3. (requires browser restart) message missing next to Language similar to other pref settings

  • Screenshot if needed:

  • Any related issues:
    Changing language should prompt to restart #4777
@srirambv srirambv added this to the 0.13.1 milestone Jan 20, 2017
@luixxiul
Copy link
Contributor

Fix here:

browser-laptop/app/extensions/brave/locales/en-US/preferences.properties

Line 185 in 7bef7d1

selectedLanguage=Language:

micopc added a commit to micopc/browser-laptop that referenced this issue Jan 21, 2017
@micopc
Add 'requires browser restart' text to Language Preference. Fix brave…
1ea7f3c 
…#6782
@micopc micopc mentioned this issue Jan 21, 2017
Merged
4 tasks
@bsclifton bsclifton modified the milestones: 0.13.2, 0.13.1 Jan 26, 2017
@luixxiul luixxiul modified the milestones: 0.13.1, 0.13.2 Jan 27, 2017
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Feb 10, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug copy/content/text QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
5 participants
@aekeus @bbondy @luixxiul @bsclifton @srirambv