Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

First option in Menu/Hamburger is selected by default #6867

Closed
srirambv opened this issue Jan 26, 2017 · 8 comments
Closed

First option in Menu/Hamburger is selected by default #6867

srirambv opened this issue Jan 26, 2017 · 8 comments
Assignees
@NejcZdovc
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.13.2

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    New Tab option in kabob/hamburgermenu is highlighted by default

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev ebea72a
    Verified not happening on RC6

  • Steps to reproduce:

    1. Do a clean install of 0.13.0 RC7
    2. Click on the kabob/hamburger menu
    3. New Tab option is highligted by default

  • Actual result:
    New Tab option is highlighted by default

  • Expected result:
    None of the options should be highlighted by default and should only highlight on mouse over

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    rc7

  • Any related issues:
@srirambv srirambv added this to the 0.13.0 milestone Jan 26, 2017
@luixxiul luixxiul removed the settings label Jan 26, 2017
@srirambv srirambv changed the title New Tab option in kabob/hamburgermenu is highlighted by default First option in Menu/Hamburger is selected by default Jan 26, 2017
@srirambv
Copy link
Collaborator Author

Same on menu as well
image

@srirambv srirambv modified the milestones: 0.13.1, 0.13.0 Jan 26, 2017
@bbondy
Copy link
Member

bbondy commented Jan 26, 2017

It will work by reverting this:
03bf66b

So I reverted it for 0.13.0 and we'll treat this as blocking for 0.13.1. Thanks.

@bbondy bbondy mentioned this issue Jan 26, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 27, 2017
@NejcZdovc
Removed default highlight from context menu
2ee1c72 
Resolves brave#6867

Auditors:
@bsclifton @bbondy

Test Plan:
-specified in brave#6867
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 27, 2017
@NejcZdovc
Removed default highlight from context menu
061ad16 
Resolves brave#6867

Auditors:
@bsclifton @bbondy

Test Plan:
-specified in brave#6867
@NejcZdovc NejcZdovc mentioned this issue Jan 27, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc self-assigned this Jan 27, 2017
bbondy added a commit that referenced this issue Jan 28, 2017
@bbondy
Merge pull request #6888 from NejcZdovc/hotfix/#6867-context-menu-def…
5fe4fb6 
…ault

Removed default highlight for context menu
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

This is not resolved yet on Windows 10 32 bit

@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

Only menus on title bar. The issue on the kabob menu was fixed

@luixxiul luixxiul reopened this Feb 4, 2017
@NejcZdovc
Copy link
Contributor

I can't reproduce it. @bsclifton can you please try it out?

@bsclifton
Copy link
Member

bsclifton commented Feb 4, 2017 •
edited
Loading

reproduced; the steps above aren't clear, but here is what I did to reproduce:

Setup:
-On Windows, go to prefs and disable "hide menu by default"
-On macOS you need to edit code

  • go to main.js and set customTitlebarEnabled to true
  • in preferences.js, make sure the hide menu by default shows
  • launch and edit prefs, disable the "hide menu by default"

Now, you will always see the menu. You can then click any of the menus and besides expanding the menu, it also selects the first item

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 4, 2017
@NejcZdovc
Fixed menu default selection in title bar
6de95f9 
Auditors: @bsclifton @luixxiul

Test Plan:
- specifined in brave#6867
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 4, 2017
@NejcZdovc
Fixed menu default selection in title bar
904b240 
Fixes brave#6867

Auditors: @bsclifton @luixxiul

Test Plan:
- specifined in brave#6867
@NejcZdovc NejcZdovc mentioned this issue Feb 4, 2017
Merged
4 tasks
bsclifton added a commit that referenced this issue Feb 4, 2017
@bsclifton
Merge pull request #7059 from NejcZdovc/hotfix/#6867-default-selectio…
826b835 
…n-menu

Fixed menu default selection in title bar
@bsclifton
Copy link
Member

PR addressing this issue was merged after I confirmed the fix; It will be in the next RC 👍

@luixxiul luixxiul mentioned this issue Feb 4, 2017
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Feb 5, 2017 •
edited
Loading

Fixed on Windows 10x64 in RC4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
6 participants
@aekeus @bbondy @luixxiul @bsclifton @NejcZdovc @srirambv