Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Enabling Enpass causes browser to hang #6984

Closed
srirambv opened this issue Feb 1, 2017 · 3 comments
Closed

Enabling Enpass causes browser to hang #6984

srirambv opened this issue Feb 1, 2017 · 3 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 1, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Enabling Enpass password manager from settings causes the application to hang and close forcefully

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.2
    rev fe018d5

  • Steps to reproduce:

    1. Do a clean install of 0.13.2 preview 1
    2. Enable Enpass as password manager under settings
    3. Browser hangs and gets closed forcefully
    4. Running from console shows error
An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property 'populate' of null
    at EventEmitter.<anonymous> (C:\Users\Sriram BV\AppData\Local\brave\app-0.13.2\resources\electron.asar\browser\api\extensions.js:487:49)
    at emitThree (events.js:116:13)
    at EventEmitter.emit (events.js:194:7)
    at WebContents.<anonymous> (C:\Users\Sriram BV\AppData\Local\brave\app-0.13.2\resources\electron.asar\browser\api\web-contents.js:164:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)

Enpass was not installed while testing this.

  • Actual result:
    Browser hangs

  • Expected result:
    Should enable password manager if app is installed, if app is not installed should do nothing

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    NA

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    enpass1

  • Any related issues:

@bbondy
Copy link
Member

bbondy commented Feb 1, 2017

seems like either this never worked or the muon support changed in v54, I think we'll have to hide the option.

@bbondy bbondy added this to the 0.13.2 milestone Feb 1, 2017
@bbondy
Copy link
Member

bbondy commented Feb 1, 2017

We'll use this bug for adding that support but it isn't a priority vs other things. I'll add a new bug for tracking hiding the setting.

@bbondy bbondy removed this from the 0.13.2 milestone Feb 1, 2017
andrewalker added a commit to andrewalker/browser-laptop that referenced this issue Jun 18, 2017
This reverts commit 29a8223.

According to issue brave#7778, particularly the comment by @mcg, support for
Enpass is already working. So the option can be re-enabled.

Fixes brave#7778, brave#5097, brave#6984.
andrewalker added a commit to andrewalker/browser-laptop that referenced this issue Jun 18, 2017
This reverts commit 29a8223.

According to issue brave#7778, particularly the comment by @mcg, support for
Enpass is already working. So the option can be re-enabled.

Fixes brave#7778, fixes brave#5097, fixes brave#6984.
@luixxiul luixxiul added this to the 0.17.x (Beta Channel) milestone Jun 23, 2017
@luixxiul luixxiul modified the milestones: 0.19.x (Nightly Channel), 0.17.x (Beta Channel) Jun 23, 2017
@luixxiul luixxiul removed this from the 0.19.x (Beta Channel) milestone Sep 20, 2017
@luixxiul
Copy link
Contributor

Enpass was hidden again with #10232. Let's revisit this one after it is shown. Tracked on #7778

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants