Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarked PDF file should have the location of the PDF file itself #7190

Closed
luixxiul opened this issue Feb 11, 2017 · 0 comments · Fixed by #7207
Closed

Bookmarked PDF file should have the location of the PDF file itself #7190

luixxiul opened this issue Feb 11, 2017 · 0 comments · Fixed by #7207
Assignees
@darkdh
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 11, 2017 •
edited by bsclifton
Loading

Test Plan

Covered by automatic test
npm run uitest -- --grep="bookmark pdf"

Original issue description

Describe the issue you encountered:
Bookmarked PDF file should have the location of the PDF file itself. Currently it includes chrome-extension://... as a prefix.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version (revision SHA): 0.13.3 RC1

  • Steps to reproduce:

    1. Open http://www.orimi.com/pdf-test.pdf
    2. Bookmark it via the star icon on the URL bar
    3. Edit the bookmark via bookmark manager

  • Actual result: It has chrome-extension://... as its prefix.

  • Expected result: The location should exclude the prefix.

  • Is this an issue in the currently released version? No

  • Can this issue be consistently reproduced? Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    clipboard01

  • Any related issues:
@luixxiul luixxiul changed the title Bookmarked PDF file should be the location of the PDF file itself Bookmarked PDF file should have the location of the PDF file itself Feb 11, 2017
@darkdh darkdh self-assigned this Feb 12, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 12, 2017
@darkdh
Sanitize PDF url before saving to site data
674fdf1 
fix brave#7190

Auditors: @bsclfton, @bbondy

Test Plan: Covered by automatic test
@darkdh darkdh mentioned this issue Feb 12, 2017
Merged
4 tasks
@bsclifton bsclifton added this to the 0.13.4 milestone Feb 13, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 14, 2017
@darkdh
Sanitize PDF url before saving to site data
583d178 
fix brave#7190

Auditors: @bsclfton, @bbondy

Test Plan: Covered by automatic test
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

Sanitize PDF url before saving to site data darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv