Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark toolbar is not shown on adding bookmark when sync is enabled #7282

Closed
srirambv opened this issue Feb 16, 2017 · 0 comments
Closed

Bookmark toolbar is not shown on adding bookmark when sync is enabled #7282

srirambv opened this issue Feb 16, 2017 · 0 comments
Assignees
@diracdeltas
Labels
bug feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 16, 2017 •
edited by luixxiul
Loading

Test plan

#7300 (comment)

  • Describe the issue you encountered:
    Bookmark toolbar is not shown on adding bookmark when sync is enabled

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 59a41eb

  • Steps to reproduce:

    1. Enable Sync from setting and enter the secret code to setup sync
    2. Visit a site in a new tab
    3. Add bookmark, bookmark toolbar is not shown after adding the bookmark

  • Actual result:
    Bookmark toolbar is not shown on adding a first bookmark

  • Expected result:
    Should either show the bookmark toolbar if it is synced or show the bookmark toolbar on adding the first bookmark on a clean profile which is synced

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Do a clean install of 0.13.5 on device 1
    2. Have sync setup on device 2
    3. Sync device 1 with device 2 by entering the secret code
    4. Visit a site and add it as a bookmark in device 1
    5. Bookmark toolbar is not shown on adding the bookmark

  • Screenshot if needed:
    bookmark

  • Any related issues:
    cc: @ayumi @darkdh @bsclifton
@srirambv srirambv added this to the 0.13.5 milestone Feb 16, 2017
@diracdeltas diracdeltas self-assigned this Feb 16, 2017
diracdeltas added a commit that referenced this issue Feb 17, 2017
@diracdeltas
Show bookmarks toolbar when bookmarks are synced for the first time
b7e0781 
Fix #7282

Auditors: @ayumi

Test Plan:
1. automated syncing bookmarks tests should pass
2. open pyramid 0, enable sync
3. open pyramid 1, sync it with pyramid 0
4. add bookmarks to pyramid 0
5. toolbar should appear in pyramid 1 once bookmarks are synced
@diracdeltas diracdeltas mentioned this issue Feb 17, 2017
Merged
4 tasks
diracdeltas added a commit that referenced this issue Feb 18, 2017
@diracdeltas
Show bookmarks toolbar when bookmarks are synced for the first time
b5c7228 
Fix #7282

Auditors: @ayumi

Test Plan:
1. automated syncing bookmarks tests should pass
2. open pyramid 0, enable sync
3. open pyramid 1, sync it with pyramid 0
4. add bookmarks to pyramid 0
5. toolbar should appear in pyramid 1 once bookmarks are synced
diracdeltas added a commit that referenced this issue Feb 18, 2017
@diracdeltas
Show bookmarks toolbar when bookmarks are synced for the first time
bfe9fca 
Fix #7282

Auditors: @ayumi

Test Plan:
1. automated syncing bookmarks tests should pass
2. open pyramid 0, enable sync
3. open pyramid 1, sync it with pyramid 0
4. add bookmarks to pyramid 0
5. toolbar should appear in pyramid 1 once bookmarks are synced
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv