Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark title is missing in edit bookmark modal after it is synced #7291

Closed
srirambv opened this issue Feb 16, 2017 · 3 comments
Closed

Bookmark title is missing in edit bookmark modal after it is synced #7291

srirambv opened this issue Feb 16, 2017 · 3 comments
Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.5

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Title missing in the bookmark on the second sync'd device

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 59a41eb

  • Steps to reproduce:

    1. Enable sync on Device 1
    2. Visit any site and bookmark it
    3. Edit the bookmark verify title is shown
    4. Enable sync on device 2 using the secret code
    5. Verify the bookmark added in step 2 is shown on device 2 as well
    6. Edit the bookmark on device 2, title is missing
    7. Edit the bookmark on device 1, title is missing there too

  • Actual result:
    Bookmark title is missing in edit bookmark modal after it is synced

  • Expected result:
    Title should be shown on both the devices

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    cc: @ayumi
@srirambv srirambv added this to the 0.13.5 milestone Feb 16, 2017
@diracdeltas
Copy link
Member

I can't repro this. It takes a minute, but editing the bookmark title in device 2 properly syncs the new title to device 1. @srirambv can you check again?

@bbondy
Copy link
Member

bbondy commented Feb 28, 2017

or @alexwykoff for extra steps

This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
@diracdeltas
Copy link
Member

i can repro this now

diracdeltas added a commit that referenced this issue Mar 2, 2017
@diracdeltas
Show default bookmark title for synced bookmarks
57108ea 
Fix #7291

Test plan:
1. open pyramid 0, enable sync, bookmark something.
2. open pyramid 1, sync to pyramid 0, wait for the synced bookmark to appear.
3. click 'edit bookmark...' on the synced bookmark in pyramid 1. the title field should not be empty.
@diracdeltas diracdeltas mentioned this issue Mar 2, 2017
Merged
4 tasks
This was referenced Mar 3, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
5 participants
@diracdeltas @bbondy @alexwykoff @luixxiul @srirambv