Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

when the browser dives into an anonize2 crypto operation, it is unresponsive for a second or so #7344

Closed
mrose17 opened this issue Feb 21, 2017 · 12 comments
Closed

when the browser dives into an anonize2 crypto operation, it is unresponsive for a second or so #7344

mrose17 opened this issue Feb 21, 2017 · 12 comments
Assignees
@bbondy
Labels
feature/rewards perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.16.x (Frozen, o...

Comments

@mrose17
Copy link
Member

mrose17 commented Feb 21, 2017 •
edited by bsclifton
Loading

Test plan

  • run the usual ledger tests to see if a wallet is created, a contribution is made, etc.

Original issue description

  • Did you search for similar issues before submitting this one? yes

  • Describe the issue you encountered: when the browser dives into an anonize2 crypto operation, it is unresponsive for a second or so

  • Platform (Win7, 8, 10? macOS? Linux distro?): all

  • Brave Version (revision SHA): all

  • Steps to reproduce:

    1. turn on the ledger, wait for the contribution period to complete and for voting to begin
    2. when a vote occurs, some seriously crypto-computation will occur, during which time the browser is unresponsive.

  • Actual result: browser briefly "locks up"

  • Expected result: browser shouldn't do that

  • Will the steps above reproduce in a fresh profile? see above

  • Is this an issue in the currently released version? yes

  • Can this issue be consistently reproduced? yes

  • Extra QA steps: none

  • Screenshot if needed: n/a

  • Any related issues: n/a
@mrose17 mrose17 added the perf label Feb 21, 2017
mrose17 added a commit that referenced this issue Mar 2, 2017
@mrose17
Initial check-in
03cba95 
For #7344
@mrose17 mrose17 self-assigned this Mar 4, 2017
@mrose17 mrose17 added this to the 1.0.1 milestone Mar 7, 2017
@mrose17 mrose17 mentioned this issue Mar 9, 2017
Closed
@mrose17 mrose17 modified the milestones: 0.13.6, 1.0.1 Mar 10, 2017
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
@bsclifton
Copy link
Member

moving to 0.14.1

@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 15, 2017
@mrose17 mrose17 mentioned this issue Mar 30, 2017
Merged
4 tasks
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 5, 2017
@bsclifton
Copy link
Member

Reverted with 91b8ebf because of a Windows only bug seen with #8304

Reopening and moving to 0.14.3 for reattempt

@bsclifton bsclifton reopened this Apr 14, 2017
@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 14, 2017
@mrose17
Copy link
Member Author

mrose17 commented Apr 18, 2017

@bridiver - apparently the v8 workers threads is okay on mac and linux, but not windows...

@bridiver
Copy link
Collaborator

@mrose17 what is the issue? Is there a bug filed for it?

@bsclifton
Copy link
Member

@bridiver you can find more info in #8304 (including the errors being logged)

@bsclifton
Copy link
Member

We should be able to try this again after attempting the fix recommended by @bridiver here:
#8304 (comment)

kspearrin pushed a commit to kspearrin/browser-laptop that referenced this issue May 11, 2017
@bbondy @kspearrin
Revert "Revert the enabling of ledger in a worker"
34b48d3 
This reverts commit db26cac.

Auditors: @bsclifton

See also
brave/muon@14c0cd7

Fix brave#7344
@cezaraugusto
Copy link
Contributor

reverted again in f1d79db after #8884. Reopening

@cezaraugusto cezaraugusto reopened this May 16, 2017
@cezaraugusto cezaraugusto mentioned this issue May 16, 2017
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.15.400, 0.15.300 May 16, 2017
@NejcZdovc NejcZdovc reopened this May 16, 2017
@alexwykoff alexwykoff modified the milestones: 0.16.200, 0.16.100 May 23, 2017
@alexwykoff alexwykoff mentioned this issue May 24, 2017
Closed
37 tasks
@luixxiul luixxiul mentioned this issue Jun 5, 2017
Merged
8 tasks
@bsclifton
Copy link
Member

Fixed with #9221

This was referenced Jun 7, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jun 8, 2017
Closed
@bbondy bbondy mentioned this issue Jun 8, 2017
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/rewards perf QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.16.x (Frozen, only critical adds fr...
Development

No branches or pull requests
9 participants
@bridiver @mrose17 @bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv