This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Hide lion badge when block count is 0 #7873
Assignees
Labels
design
A design change, especially one which needs input from the design team.
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
srirambv
added
design
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 24, 2017
Resolves brave#7873 Auditors: @bsclifton @luixxiul Test Plan: - go to brave.com - badge should be hidden
srirambv
changed the title
bsclifton
pushed a commit
that referenced
this issue
Mar 25, 2017
Resolves #7873 Auditors: @bsclifton @luixxiul Test Plan: - go to brave.com - badge should be hidden
This was referenced Mar 28, 2017
This was referenced Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Hide lion badge when adcount is 0
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
Brave 0.14.0
rev ffa6f8f
Steps to reproduce:
Actual result:
Lion badge shows count as 0
Expected result:
Should not show badge when count is 0. Should only shown when (block count)>=1
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
N/A
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
cc: @NejcZdovc
The text was updated successfully, but these errors were encountered: