Close tab button color on private tab should be something different

[luixxiul]

Describe the issue you encountered:

How about making it #fff or dark purple?

• Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

• Brave Version (revision SHA): 0.14.0 RC1

• Steps to reproduce:

  1. Open a private tab
  2. Hover on the tab

• Actual result: see above

• Expected result: CC @bradleyrichter

• Extra QA steps:
  1.
  2.
  3.

• Any related issues: Change closeTab icon from circled to squared #7851 Disable close button on tabs if tab size is too small #5431

[NejcZdovc]

@luixxiul will #7943 solve this issue?

[luixxiul]

It is not suggested there, and it is just my idea. I would like to hear @bradleyrichter 's insight at first.

[srirambv]

I think making it white would be good. Would be a good contrast on the dark tab color

[NejcZdovc]

@luixxiul why I asked about relevance to the issue #7943 is because this issue will remove purple background

[luixxiul]

I thought there was not suggested to remove the background color. Isn't It just the matter of when to have its color?

Private tabs should have its color (purple) only ...

[NejcZdovc]

Yeah, but when it's not active, private tab has no background

[bradleyrichter]

@luixxiul @NejcZdovc The reason is that the non-active purple tab is very confusing when determining which tab is actually selected.

The icon should be enough to remind you that it is private when not selected. Purple adds to recognition when it is selected.

[luixxiul]

Closing as stale (and invalid)