Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update UI spec for private tabs #7943

Closed
cezaraugusto opened this issue Mar 29, 2017 · 1 comment
Closed

Update UI spec for private tabs #7943

cezaraugusto opened this issue Mar 29, 2017 · 1 comment

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 29, 2017

Test plan

  1. Open a new private tab
  2. Switch between private tab and a regular tab. When not active, the private tab should not be purple
  3. When active, the private tab should always be purple
  4. Private tab should always have the 🕶 icon

Original issue description

Per @bradleyrichter request:

  1. Private tabs should have its color (purple) only when active, no hoverState
  2. Private tabs color should override themeColor
  3. Replace 👁 icon with 🕶

screen shot 2017-03-28 at 11 43 32 pm

@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. feature/tabsbar labels Mar 29, 2017
@cezaraugusto cezaraugusto added this to the 0.14.0 milestone Mar 29, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 29, 2017
@bbondy bbondy modified the milestones: 0.14.1, 0.14.0 Mar 29, 2017
@bbondy
Copy link
Member

bbondy commented Mar 29, 2017

No new UI changes pls once we're in RC for that milestone. Unless it's a regression or big problem. I think it's neither of those so I updated to 0.14.1

@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 29, 2017
bsclifton pushed a commit that referenced this issue Mar 29, 2017
@alexwykoff alexwykoff changed the title Update UI spec for private tabs Fixed UI for private tabs Mar 30, 2017
bridiver pushed a commit that referenced this issue Apr 4, 2017
@luixxiul luixxiul changed the title Fixed UI for private tabs Update UI spec for private tabs Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants