Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor loginRequired.js with Aphrodite and commonForm #8009

Closed
luixxiul opened this issue Mar 31, 2017 · 0 comments
Closed

Refactor loginRequired.js with Aphrodite and commonForm #8009

luixxiul opened this issue Mar 31, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 31, 2017

Test plan

#8011 (comment)


Describe the issue you encountered: Refactor loginRequired.js with Aphrodite, applying .commonForm (which shall be implemented with PR #7995) instead of .genericForm

Currently there are only three other instances where .genericForm is applied (autofillAddressPanel.js, autofillCreditCardPanel.js, and addEditBookmarkHanger.js), and in every case styles which genericForm defines are overwritten by what commonForm is going to do so (title color, padding inside the dialog, etc). Keeping both of them is a cause of style inconsistency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.