This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Create commonForm.js and refactor importBrowserDataPanel.js #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the comparison.
|
luixxiul
changed the title
This was referenced Mar 31, 2017
NejcZdovc
reviewed
Apr 3, 2017
app/renderer/components/dropdown.js
Outdated
| @@ -30,6 +31,12 @@ class FormDropdown extends ImmutableComponent { | |||
| } | |||
| } | |||
|
|
|||
| class CommonFormDropdown extends ImmutableComponent { | |||
There was a problem hiding this comment.
I would move this component into commonForm.js as well
There was a problem hiding this comment.
added 2 commits
April 5, 2017 03:37
Closes #7990 Closes #7996 Addresses #7989 - Created commonForm.js to make it possible to apply commonForm to other form elements, which are .importBrowserDataPanel, .manageAutofillDataPanel, and .checkDefaultBrowserDialog for now It includes CommonForm, CommonFormClickable, CommonFormSection, CommonFormTitle, CommonFormSubSection, CommonFormButtonWrapper, and CommonFormBottomWrapper. - Created CommonFormDropdown - Set margin-bottom with dropdownWrapper - Introduced new variables commonFormBottomWrapperBackground and commonFormBackground to global.js Auditors: Test Plan: 1. Select "Import Browser Data..." from the main menu 2. Make sure the dropdown works 3. Make sure every data can be imported with the dialog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7990
Closes #7996
Addresses #7989
Created
commonForm.jsto make it possible to apply commonForm to other form elements, which are.importBrowserDataPanel,.manageAutofillDataPanel, and.checkDefaultBrowserDialogfor now. See: fc9902cIt includes
CommonForm,CommonFormClickable,CommonFormSection,CommonFormTitle,CommonFormSubSection,CommonFormButtonWrapper, andCommonFormBottomWrapper.Created
CommonFormDropdownSet margin-bottom with
dropdownWrapperIntroduced new variables
commonFormBottomWrapperBackgroundandcommonFormBackgroundto global.jsThe former was set to tabsBackground, and the latter to toolbarBackground.
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).