Allow <site> to <action>?

[mrose17]

originally this was about flash, but #8828 fixes that.

however, i am pretty sure than whenever someone answers "No" to an "Allow to " and selects "Remember this decision", then it is never remembered regardless of the choice. i know this is also the case with autoplay.

can we please have a systematic search of the code for all cases and ensure it works right?

Test plan

#8828 (comment)

---

• Did you search for similar issues before submitting this one? yes.

• Describe the issue you encountered: "Allow ... to run Flash Player?" with "Remember this decision" doesn't seem

• Platform (Win7, 8, 10? macOS? Linux distro?): MacOS

• Brave Version (revision SHA): 4e86cab

• Steps to reproduce:

  1. go to a site that will cause the "Allow ... to run Flash Player?" notification
  2. click on "Remember this decision"
  3. click on "Deny"

• Actual result: the setting is not remembered

• Expected result: the setting is remembered

• Will the steps above reproduce in a fresh profile? yes

• Is this an issue in the currently released version? yes

• Can this issue be consistently reproduced? yes

• Extra QA steps: none

• Screenshot if needed: see below

• Any related issues: none

[mrose17]

@bsclifton - here is the first issue we discussed.

[diracdeltas]

pretty sure that 'remember this decision' + 'deny' never worked (only 'remember' + 'allow') so this isn't a regression