Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Redux component - Download area #9260

Closed
NejcZdovc opened this issue Jun 5, 2017 · 0 comments · Fixed by #9271
Closed

Redux component - Download area #9260

NejcZdovc opened this issue Jun 5, 2017 · 0 comments · Fixed by #9271
Assignees
@NejcZdovc
Labels
feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.18.x Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 5, 2017 •
edited by luixxiul
Loading

Test plan

#9271 (comment)

Describe the issue you encountered:
Refactor DownloadsBar and DownloadItem into redux component
@NejcZdovc NejcZdovc added this to the 0.18.x milestone Jun 5, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 5, 2017
@NejcZdovc NejcZdovc mentioned this issue Jun 6, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 6, 2017
@NejcZdovc
Coverts DownloadItem and DownloadsBar
f67a0ca 
Resolves brave#9260

Auditors: @bsclifton

Test Plan:
- download an item
- check if download item is shown
- check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 6, 2017
@NejcZdovc
Coverts DownloadItem and DownloadsBar
e196682 
Resolves brave#9260

Auditors: @bsclifton

Test Plan:
- download an item
- check if download item is shown
- check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 6, 2017
@NejcZdovc
Coverts DownloadItem and DownloadsBar
5584d38 
Resolves brave#9260

Auditors: @bsclifton

Test Plan:
- download an item
- check if download item is shown
- check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 6, 2017
@NejcZdovc
Coverts DownloadItem and DownloadsBar
32bad94 
Resolves brave#9260

Auditors: @bsclifton

Test Plan:
- download an item
- check if download item is shown
- check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 6, 2017
@NejcZdovc
Coverts DownloadItem and DownloadsBar
5a6bbfa 
Resolves brave#9260

Auditors: @bsclifton

Test Plan:
- download an item
- check if download item is shown
- check if you can interact with it (note there is a problem with pause/resume, fixed here brave#9246)
This was referenced Jul 24, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
@srirambv srirambv mentioned this issue Jul 26, 2017
Closed
This was referenced Jul 26, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.18.x Release
Development

Successfully merging a pull request may close this issue.

Converts DownloadItem and DownloadsBar into redux NejcZdovc/browser-laptop
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags