Closing Tabs Results in White Page

[jonathansampson]

Test plan

See #9539
Also #9542 (comment) for 0.18

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Upon closing 2 tabs, the user may be presented with a white page.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Desktop

• Brave Version (revision SHA):
  75ffa36

• Steps to reproduce:

  1. Open 7 tabs (7th tab selected)
  2. Click x on 6th tab (don't move mouse)
  3. Click x on 7th tab (should move under your mouse)

• Actual result:
  Focused tab is white.

• Expected result:
  Focused tab is visible to the user.

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes

• Can this issue be consistently reproduced?
  Yes

[bridiver]

may means it is intermittent? Or can you reliably repro?

[jonathansampson]

@bridiver I was able to reproduce it 100% of the time (as was @NejcZdovc I believe) when I carefully followed the steps above. Make sure you close both right-most tabs without moving your mouse.

I'm also seeing this issue when closing tabs; rather than a full-white tab, I get a preview tab. This is particularly odd since I have tab previews disabled.

[cezaraugusto]

so issue happens for any prefs config for "When closing an active tab" option

issue reported above (#9306 (comment)) is different than the main issue. I created a new one for that #9536 with fix under #9537. /cc @jonathansampson

Seems that issue happened after 0391096. For me, following the STR it is always falling in under this conditional 0391096#diff-585bc5df4db53a44a36b51f6bd4e0bc3R36. Given next frame is a user decision, I'm not sure what is expected in this case.

@bridiver do you mind jumping in to see what's going wrong? I created a failing test case in #9539.

[bridiver]

thanks for the test case @cezaraugusto ! I have an idea of what the issue might be and should be able to track it down pretty quickly

[bridiver]

Haven't checked the test run yet and probably needs a unit test update, but the new test passes

…

On Jun 17, 2017, at 12:06 PM, Cezar Augusto ***@***.***> wrote: so issue happens for any prefs config for "When closing an active tab" option issue reported above (#9306 (comment)) is different than the main issue. I created a new one for that #9536 with fix under #9537. /cc @jonathansampson Seems that issue happened after 0391096. For me, following the STR it is always falling in under this conditional 0391096#diff-585bc5df4db53a44a36b51f6bd4e0bc3R36. Given next frame is a user decision, I'm not sure what is expected in this case. @bridiver do you mind jumping in to see what's going wrong? I created a failing test case in #9539. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.