titleMode does not activate reliably

[cezaraugusto]

Aside from edge cases like new tab page, title mode once activated should always be shown when mouse is not over navigation chrome, and be hidden (visible urlbar) when mouse is over it.

Given the above rule, at this moment we have two issues with titleMode:

on macOS

1. Have the window not maximized
2. Move mouse over navigation content.
3. urlbar is active, that's ok
4. Move mouse out of window

Result:
urlBar is still active

Expected
Given the mouse is not over navigation content, titleMode should be active (urlbar should be hidden)

on Windows

1. Have the window not maximized
2. Move mouse over navigation content.
3. urlbar is active, that's ok
4. Move mouse out of window
5. titleMode is active, that's ok
6. Move mouse from top of the window up to website's title

Result:
titleMode is still there, you can't hit urlbar

Expected
Given the mouse is over navigation content, titleMode should be removed (urlbar should be active)

[srirambv]

@cezaraugusto This doesnt seem right yet on Windows.

[srirambv]

@cezaraugusto This is still an issue on Windows. Mouse over tabs bar reveals URL bar but when moved quickly goes back to title mode. With mouse outside the window hover back on browser doesn't switch to URL mode and remains in title mode

[Jacalz]

Yeah huge issue using windows 10 on my computer

[bsclifton]

@srirambv IIRC, because of this issue we set title mode as OFF by default (for new installs). Can you confirm this?

[srirambv]

@bsclifton Yes this is an annoying issue on Windows when title mode is enabled. Both on new profile or on update. In fact it is quite impossible to click in URL when title mode is enabled as the URL mode only comes when the mouse is on tabs bar. Once it moves out of URL bar it switches back to title mode. Only shows for new tabs, existing tabs with pages loaded its impossible to click in URL bar using mouse. Have to use keyboard shortcut.

[bsclifton]

Removing milestone as this issue is not release blocking. See above input @cezaraugusto

[srirambv]

+1 from https://community.brave.com/t/bug-report-always-show-the-url-bar-function/13984

[cezaraugusto]

I don't have time to look at this so I'm un-assigning me, leaving it open for grabs.

For the people interested in solving this bug:

We have a CSS property called -webkit-app-region: drag; (navigationBar.less is the go-to file to find it) which allows the window chrome (the gray area) to be draggable. While this works fine, the property cancels all mouse events in the area it covers, which is why the onMouseEnter event is never fired (and the titleMode never disappears).

This is a known bug both in Chromium and Electron but hopefully, some tweaks in urlbar/titemode sizing and elements rearrangements might fix this.

The plan is to:

• Keep the window draggable as it is now;
• Re-organize the drag property so we could access via mouse events the urlbar.

[cezaraugusto]

also note that this is a Windows-only bug.

[MargarytaChepiga]

I was trying to take a look at this, but I am not able to reproduce it. I am using Windows 10 x64.