Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Redux component - BookmarksToolbar and BookmarkToolbarButton #9421

Closed
NejcZdovc opened this issue Jun 13, 2017 · 2 comments
Closed

Redux component - BookmarksToolbar and BookmarkToolbarButton #9421

NejcZdovc opened this issue Jun 13, 2017 · 2 comments
Assignees
@NejcZdovc
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 13, 2017 •
edited
Loading

Test plan:

  1. make sure that bookmarks and folders are displayed
  2. make sure that you ran reorder bookmarks

Describe the issue you encountered:
Converts bookmarksToolbar and bookmarkToolbarButton into redux.
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 13, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 13, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
3af4af3 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 16, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
341aa7c 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 16, 2017
Merged
7 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 16, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
312a6a0 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 20, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
3f91c3a 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 20, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
e21ade1 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 20, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
eaa5d50 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 22, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
92b3067 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 22, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
0532b52 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
ee53b4c 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
488cf31 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
e3eeff8 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
7c1d22f 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 23, 2017
@NejcZdovc
Converts bookmarksToolbar and bookmarkToolbarButton into redux
5f6f453 
Resolves brave#9421

Auditors: @bsclifton @bridiver

Test Plan:
@kjozwiak
Copy link
Member

@NejcZdovc is there a test case/test plan that can be used to test this particular fix? If there's no way to test this, please add the QA/no-qa-needed label.

@NejcZdovc
Copy link
Contributor Author

@kjozwiak done

This was referenced Sep 27, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 28, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @luixxiul @NejcZdovc @srirambv @LaurenWags