Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only primitives in UrlBarIcon #9753

Closed
NejcZdovc opened this issue Jun 28, 2017 · 0 comments
Closed

Only primitives in UrlBarIcon #9753

NejcZdovc opened this issue Jun 28, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 28, 2017 •
edited by luixxiul
Loading

Test plan

#9754 (comment)

Describe the issue you encountered:
Remove activeFrame prop from merge props. Replace it with activeFrameKey and create new window action for prepareBookmarkDataFromCompatible
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 28, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 28, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
5bccd02 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 28, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc added the perf label Jun 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 29, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
48e1584 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 29, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
e0827f5 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
5bec429 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 30, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
a9f9b0b 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 5, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
1984a85 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 5, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
1dec383 
Resolves brave#9753

Auditors: @bsclifton @bridiver

Test Plan:
NejcZdovc added a commit that referenced this issue Jul 5, 2017
@NejcZdovc
Merge pull request #9754 from NejcZdovc/refactor/#9753-urlbaricon
4cc7d68 
UrlBarIcon uses now only primitives
NejcZdovc added a commit that referenced this issue Jul 5, 2017
@NejcZdovc
UrlBarIcon uses now only primitives
d82f171 
Resolves #9753

Auditors: @bsclifton @bridiver

Test Plan:
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Sep 20, 2017
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Sep 25, 2017
Closed
@srirambv srirambv mentioned this issue Sep 26, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@luixxiul @NejcZdovc @srirambv @LaurenWags