Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add 'always block' option to autoplay #9755

Closed
alexwykoff opened this issue Jun 28, 2017 · 5 comments · Fixed by #12159
Closed

Add 'always block' option to autoplay #9755

alexwykoff opened this issue Jun 28, 2017 · 5 comments · Fixed by #12159
Assignees
@darkdh
Labels
feature/autoplay priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). product/user-happiness QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Milestone
0.22.x (Release C...

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jun 28, 2017 •
edited by luixxiul
Loading

Test plan

#12159 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Users in community are asking for the option to always block autoplay and do not ask/show a notification per each domain.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):

0.18.x
@alexwykoff alexwykoff added design A design change, especially one which needs input from the design team. suggestion labels Jun 28, 2017
@alexwykoff
Copy link
Contributor Author

screen shot 2017-09-08 at 12 28 33 pm

@srirambv
Copy link
Collaborator

+1 from community https://community.brave.com/t/add-autoplay-request/7663

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). product/user-happiness and removed priority/high (deprecated) design A design change, especially one which needs input from the design team. labels Nov 22, 2017
@darkdh darkdh self-assigned this Dec 1, 2017
darkdh added a commit that referenced this issue Dec 1, 2017
@darkdh
Add always deny options support
7ebba13 
(It won't popup notification if media is blocked)

fix #9755

Auditors: @bsclifton

Test Plan:
a. Manual Test
1. Go to about:preferences#security
2. Set Autoplay Media to `Always deny`
3. Visit https://www.cnet.com/news/mozilla-layoff-firefox-device-relevance/
4. It should blocked video without asking users

b Automatic Test
Covered by unit test
@darkdh darkdh mentioned this issue Dec 1, 2017
Merged
8 tasks
darkdh added a commit that referenced this issue Dec 21, 2017
@darkdh
Add always deny options support
1442c27 
(It won't popup notification if media is blocked)

fix #9755

Auditors: @bsclifton

Test Plan:
a. Manual Test
1. Go to about:preferences#security
2. Set Autoplay Media to `Always deny`
3. Visit https://www.cnet.com/news/mozilla-layoff-firefox-device-relevance/
4. It should blocked video without asking users

b Automatic Test
Covered by unit test
@cezaraugusto cezaraugusto modified the milestones: Backlog (Prioritized), 0.22.x (Nightly Channel) Dec 22, 2017
@bsclifton bsclifton modified the milestones: 0.22.x (Nightly Channel), 0.20.x (Beta Channel) Jan 3, 2018
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
This was referenced Jan 5, 2018
Closed
Closed
@LaurenWags
Copy link
Member

@darkdh on MacOS video plays but is muted with 'Always Deny' as the option:
9755-019126

@LaurenWags LaurenWags reopened this Jan 5, 2018
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 11 (Release Channel), 0.19.x Hotfix 12, 0.20.x (Beta Channel) Jan 5, 2018
@darkdh
Copy link
Member

darkdh commented Jan 9, 2018

fixed in muon 4.6.7

@darkdh darkdh closed this as completed Jan 9, 2018
This was referenced Jan 9, 2018
Closed
Closed
Closed
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Jan 9, 2018
This was referenced Feb 20, 2018
Closed
Closed
This was referenced Mar 22, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autoplay priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). product/user-happiness QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Add always deny options support brave/browser-laptop
8 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @darkdh @srirambv @LaurenWags @btlechowski