Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update extensionsTab to the modified BEM style #10208

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Update extensionsTab to the modified BEM style #10208

merged 1 commit into from
Aug 3, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 30, 2017 •
edited
Loading

Submitter Checklist:

Closes #10207

Test Plan:

  1. Open about:preferences#extensions
  2. Make sure the table is properly displayed
  3. Scroll the page to the bottom
  4. Make sure the information div has margin-bottom: 40px
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul self-assigned this Jul 30, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 30, 2017
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Jul 30, 2017
@brave brave deleted a comment from codecov-io Jul 30, 2017
@codecov-io
Copy link

codecov-io commented Jul 30, 2017 •
edited
Loading

Codecov Report

Merging #10208 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10208      +/-   ##
==========================================
+ Coverage   52.79%   52.79%   +<.01%     
==========================================
  Files         227      227              
  Lines       20214    20215       +1     
  Branches     3236     3236              
==========================================
+ Hits        10672    10673       +1     
  Misses       9542     9542
Flag Coverage Δ
#unittest 52.79% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...p/renderer/components/preferences/extensionsTab.js 89.65% <100%> (+0.18%) ⬆️

Update extensionsTab to the modified BEM style
912675e 
Also:
- Remove flex from the top container as displaying the footer on the bottom is inconsistent compared with the other tabs

Closes #10207

Test Plan:
1. Open `about:preferences#extensions`
2. Make sure the table is properly displayed
3. Scroll the page to the bottom
4. Make sure the information div has `margin-bottom: 40px`
cezaraugusto
cezaraugusto approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 991ab34 into brave:master Aug 3, 2017
@luixxiul luixxiul mentioned this pull request Aug 3, 2017
Closed
@luixxiul luixxiul deleted the polish-bem-extensionsTab branch August 3, 2017 10:15
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 3, 2017

@cezaraugusto thanks for the review!

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 3, 2017

Follow-up PR: #10265. See https://github.com/brave/browser-laptop/pull/10265/files for update of extensionsTab.js.

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@luixxiul luixxiul

Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging this pull request may close these issues.
4 participants
@luixxiul @codecov-io @cezaraugusto @bbondy