-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
e.sender.send(messages.INITIALIZE_WINDOW, | ||
{ | ||
|
||
const mem = muon.shared_memory.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't there already a commit for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in 0.18.x, this PR is against 0.18.x, so it wouldn't show this diff if there was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ see comments
Misunderstanding on my part 😄 I don't see the changes in master yet though, so we may still want to cherry-pick this commit and PR against master |
I'm unable to save state after this change, getting this err:
opened #10332 |
Should be fixed after Muon version is upgraded 👍 (all branches now updated- sorry I missed that) |
confirmed working thanks |
Fix #10292
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests