Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix the issue that the title of unloaded tabs shift down #10869

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Fix the issue that the title of unloaded tabs shift down #10869

merged 1 commit into from
Sep 14, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 9, 2017

by specifying the height in pixel

Follow-up to #10533. The issue is a regression introduced with that PR.

Auditors:

Test Plan:

  1. Open the browser
  2. Load several tabs
  3. Close the browser
  4. Re-open it
  5. Make sure the unloaded tab titles are not shifted down

I cannot find the exact STR but I have seen the issue several times already.

screenshot 2017-09-10 11 43 44

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

by specifying the height in pixel

Follow-up to #10533

Auditors:

Test Plan:
1. Open the browser
2. Load several tabs
3. Close the browser
4. Re-open it
5. Make sure the tab titles are not shifted down
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 9, 2017
@luixxiul luixxiul self-assigned this Sep 9, 2017
@luixxiul luixxiul added the priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. label Sep 13, 2017
@ghost ghost added the sprint/1 label Sep 13, 2017
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 5d4251c into brave:master Sep 14, 2017
@luixxiul luixxiul deleted the polish-tabs-styles branch September 14, 2017 08:06
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/tabsbar priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants