Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add comment blocks to about:styles #11522

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Add comment blocks to about:styles #11522

merged 1 commit into from
Oct 28, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Oct 14, 2017

Follow-up to #10978 (comment)

Auditors: @cezaraugusto

Test Plan:

  1. Open about:styles

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Follow-up to #10978 (comment)

Auditors: @cezaraugusto

Test Plan:
1. Open about:styles
@luixxiul luixxiul self-assigned this Oct 14, 2017
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. labels Oct 14, 2017
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Oct 14, 2017
@codecov-io
Copy link

Codecov Report

Merging #11522 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11522      +/-   ##
==========================================
- Coverage   52.66%   52.62%   -0.04%     
==========================================
  Files         268      268              
  Lines       25218    25218              
  Branches     4022     4022              
==========================================
- Hits        13280    13271       -9     
- Misses      11938    11947       +9
Flag Coverage Δ
#unittest 52.62% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.27% <0%> (-0.31%) ⬇️

@bbondy bbondy modified the milestones: 0.22.x (Nightly Channel), Backlog Oct 25, 2017
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 9227662 into brave:master Oct 28, 2017
@luixxiul luixxiul modified the milestones: Backlog, 0.22.x (Nightly Channel) Oct 28, 2017
@luixxiul luixxiul deleted the update-about-styles branch October 28, 2017 06:46
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants