Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Changed share l10n string to use a generic template for each share menu items #12443

Closed
wants to merge 1 commit into from
Closed

Changed share l10n string to use a generic template for each share menu items #12443

wants to merge 1 commit into from

Conversation

sergio-rojasa
Copy link

@sergio-rojasa sergio-rojasa commented Dec 29, 2017

Fix #8604

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. Build from the source: npm run watch
  2. Run Brave: npm run start
  3. In the URL bar type: https://www.brave.com/
  4. On the menu bar click on File.
  5. Under File look for Share.
  6. Under Share click on one item with share page.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant