Changed share l10n string to use a generic template for each share menu items.

[sergio-rojasa]

Fix #8604

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

1. Build from the source: npm run watch
2. Run Brave: npm run start
3. In the URL bar type: https://www.brave.com/
4. On the menu bar click on File.
5. Under File look for Share.
6. Under Share click on one item with share page.

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[NejcZdovc]

Can you change this one to locale.translation(l10nId, {siteName: siteName})? We already have a mechanism for variables in the translations.

[sergio-rojasa]

I tried your suggestion and I tried other way using ${locale.translation(l10nId)} ${siteName} but it also didn't work. when I lookup locale.translation, I found out that it only accepted one argument.

[NejcZdovc]

not sure that I follow, this change is not working for you?

[sergio-rojasa]

The change is not working for me.

[NejcZdovc]

ok, let me try it

[NejcZdovc]

ok I see what's going on, will fix it, so that this will work as well

[NejcZdovc]

@sergiorojasa ok this should be working now, can you please check out if everything is ok now? I pushed my fix commit to your PR

[NejcZdovc]

++ thank you for this 👍

[srirambv]

++ Manually test looks good. 👍

[bsclifton]

@sergiorojasa congrats on your first merged PR! 😄 👍 Thanks!