Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Returning to the recovery modal after a wallet recovery failure #13243

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Feb 21, 2018

Fixes #11422

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

1. Visit about:preferences#payments and create a wallet
2. Select "Advanced Settings" -> "Recover your wallet"
3. Select "Recover" and press "OK" on the "Recovery Failed" message
4. Ensure that the Recover Your Brave Wallet modal stays open

[Regression]
1. Visit about:preferences#payments and create a wallet
2. Select "Advanced Settings" -> "Recover your wallet"
3. Enter in a valid recovery key and select "Recover"
4. Hit "OK" on the success message
5. Ensure that the Recovery Your Brave Wallet modal dissapears

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

clearRecoveryStatus() inside the LedgerRecoveryContent component would hide all the advanced overlays no matter the outcome. This binds a success variable (bool) and only hides the advanced overlays on success.

An automated test was added for this. Additionally, recoveryOverlayErrorButton was added to the test selectors.

@ryanml
Copy link
Contributor Author

ryanml commented Feb 21, 2018

cc: @kjozwiak @NejcZdovc

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #13243 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13243      +/-   ##
==========================================
- Coverage   55.94%   55.94%   -0.01%     
==========================================
  Files         281      281              
  Lines       27831    27832       +1     
  Branches     4563     4564       +1     
==========================================
  Hits        15570    15570              
- Misses      12261    12262       +1
Flag Coverage Δ
#unittest 55.94% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...r/components/preferences/payment/ledgerRecovery.js 37.25% <0%> (-0.75%) ⬇️

@NejcZdovc NejcZdovc self-requested a review February 22, 2018 04:30
@NejcZdovc NejcZdovc added this to the 0.23.x (Nightly Channel) milestone Feb 23, 2018
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ looks good. Thank you 👍

@NejcZdovc NejcZdovc merged commit b75cad9 into brave:master Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants