Setting tor path relative to browser laptop #13455

jumde · 2018-03-15T17:02:58Z

No description provided.

darkdh · 2018-03-15T18:49:02Z

app/browser/tabs.js

@@ -1015,6 +1016,7 @@ const api = {
          createProperties.isolated_storage = true
          createProperties.parent_partition = ''
          createProperties.tor_proxy = 'socks5://127.0.0.1:9050'
+          createProperties.tor_path = getExtensionsPath('tor') + '/tor'


it is better to use getExtensionsPath('bin') so that we can have different binary in it like geth
and also need to check platform for Windows in order to use tor.exe

darkdh

Look good to me.

diracdeltas · 2018-03-15T20:38:39Z

app/browser/tabs.js

@@ -1015,6 +1016,7 @@ const api = {
          createProperties.isolated_storage = true
          createProperties.parent_partition = ''
          createProperties.tor_proxy = 'socks5://127.0.0.1:9050'
+          createProperties.tor_path = getExtensionsPath('bin') + '/tor'


better to use path.join here

yeah, or we will get trouble on Windows

diracdeltas · 2018-03-15T20:39:02Z

app/filtering.js

@@ -691,6 +692,7 @@ const initPartition = (partition) => {
    options.isolated_storage = true
    options.parent_partition = ''
    options.tor_proxy = 'socks5://127.0.0.1:9050'
+    options.tor_path = getExtensionsPath('bin') + '/tor'


same as above

diracdeltas

path.join

darkdh

tor.exe

darkdh

++

diracdeltas · 2018-03-16T21:56:04Z

app/browser/tabs.js

@@ -1015,6 +1017,11 @@ const api = {
          createProperties.isolated_storage = true
          createProperties.parent_partition = ''
          createProperties.tor_proxy = 'socks5://127.0.0.1:9050'
+          if (process.platform === 'win32') {
+            createProperties.tor_path = path.join(getExtensionsPath('bin'), 'tor.exe').quote()


why is quote needed? String.prototype.quote does not appear to be supported on my version of Node (on MacOS)

#if defined(OS_WIN) // Windows-specific LaunchProcess that takes the command line as a // string. Useful for situations where you need to control the // command line arguments directly, but prefer the CommandLine version // if launching Chrome itself. // // The first command line argument should be the path to the process, // and don't forget to quote it. // // Example (including literal quotes) // cmdline = "c:\windows\explorer.exe" -foo "c:\bar\" BASE_EXPORT Process LaunchProcess(const string16& cmdline, const LaunchOptions& options);

i see - did someone verify on windows that string.quote() works? it's non-standard https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/quote

Support isolated_storage and tor_proxy requires brave/muon#473 Use Session::IsOffTheRecord to detect private tab requires brave/muon@edad1b2 Set Tor new identify fix #12997 requires brave/muon@7e052dd Session::IsOffTheRecord for app/filtering Refresh page after getting new identity requires brave/muon@c3d6769 implement switch Tor Private Tabs in about:newtab set isTor depending on tor private tab setting and tor availability close/re-open private tab when tor switch is toggled Recreate tor private tab at the same index it was previously at always enable new identity button for now Disable search suggestions in private mode for Tor Fix #13064 set ddg as default search engine in tor private tabs fix #13212 Disable webtorrent in tor private mode fix #13063 load favicons in Tor tabs as data: URLs fix #13065 Omit unlocked icon for HTTP onion sites Fix #12990 also fix unittests Test Plan: 1. go to http://3expgpdnrrzezf7r.onion/ in a private tab 2. no icon should be in the urlbar 3. go to https://3g2upl4pq6kufc4m.onion/ 4. you should see a lock icon disable webrtc in tor mode fix #13397 add note to shields panel about breakage in tor mode Tor binary path will be passed from browser-laptop (#13455) Disable widevine notification on Tor tabs needed for #13396 Test Plan: 1. go to https://shaka-player-demo.appspot.com in a tor private tab 2. you should not see a widevine notification disable plugins in Tor private tabs Workaround browser-context-created not being emitted for tor tabs Disable flash click to play on tor tabs TODO: figure out a way to disable widevine on a per-tab basis Test Plan: 1. ensure flash is installed and enabled in preferences 2. go to https://get.adobe.com/flashplayer/about/ 3. make sure there is no popup asking you to run flash 4. right click on the flash click-to-play element (looks like a puzzle piece) on the page. no context menu should appear. deny geolocation in tor mode fix #13447 implement new tor tabs mockup fix #12922 implement new Tor New Identity UX fix #13658 Test Plan: 1. open new private tab 2. go to check.torproject.org and open shields 3. click 'new circuit' button in shields 4. it should reload the page and show a new IP 5. open shields again, click the info circle next to 'new circuit' 5. it should open a FAQ page Bundling tor with Brave Set the tor socks port and data directory. (#13641) Pass the port and data directory down for tor to use depending on channel bind tor new circuit to hard refresh in tor tabs fix #13925 upgrade to muon 6.1.0 for tor API support

jumde requested review from diracdeltas and darkdh March 15, 2018 17:03

darkdh suggested changes Mar 15, 2018

View reviewed changes

darkdh approved these changes Mar 15, 2018

View reviewed changes

diracdeltas reviewed Mar 15, 2018

View reviewed changes

diracdeltas suggested changes Mar 15, 2018

View reviewed changes

darkdh suggested changes Mar 16, 2018

View reviewed changes

jumde force-pushed the tor_path branch 2 times, most recently from f14bc9c to be9bd31 Compare March 16, 2018 19:34

darkdh approved these changes Mar 16, 2018

View reviewed changes

diracdeltas reviewed Mar 16, 2018

View reviewed changes

Tor binary path will be passed from browser-laptop

ec1d9a4

jumde force-pushed the tor_path branch from be9bd31 to ec1d9a4 Compare March 16, 2018 23:11

diracdeltas approved these changes Mar 17, 2018

View reviewed changes

diracdeltas merged commit 3770a5b into feature/tor Mar 17, 2018

darkdh pushed a commit that referenced this pull request Mar 24, 2018

Tor binary path will be passed from browser-laptop (#13455)

6b21aff

diracdeltas pushed a commit that referenced this pull request Mar 27, 2018

Tor binary path will be passed from browser-laptop (#13455)

e553c87

darkdh pushed a commit that referenced this pull request Apr 3, 2018

Tor binary path will be passed from browser-laptop (#13455)

0d55164

bsclifton deleted the tor_path branch May 31, 2018 16:27

bsclifton restored the tor_path branch May 31, 2018 16:27

bsclifton deleted the tor_path branch June 28, 2018 00:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting tor path relative to browser laptop #13455

Setting tor path relative to browser laptop #13455

jumde commented Mar 15, 2018

darkdh Mar 15, 2018

darkdh left a comment

diracdeltas Mar 15, 2018

darkdh Mar 15, 2018

diracdeltas Mar 15, 2018

diracdeltas left a comment

darkdh left a comment

darkdh left a comment

diracdeltas Mar 16, 2018

darkdh Mar 16, 2018

diracdeltas Mar 16, 2018

Setting tor path relative to browser laptop #13455

Setting tor path relative to browser laptop #13455

Conversation

jumde commented Mar 15, 2018

darkdh Mar 15, 2018

Choose a reason for hiding this comment

darkdh left a comment

Choose a reason for hiding this comment

diracdeltas Mar 15, 2018

Choose a reason for hiding this comment

darkdh Mar 15, 2018

Choose a reason for hiding this comment

diracdeltas Mar 15, 2018

Choose a reason for hiding this comment

diracdeltas left a comment

Choose a reason for hiding this comment

darkdh left a comment

Choose a reason for hiding this comment

darkdh left a comment

Choose a reason for hiding this comment

diracdeltas Mar 16, 2018

Choose a reason for hiding this comment

darkdh Mar 16, 2018

Choose a reason for hiding this comment

diracdeltas Mar 16, 2018

Choose a reason for hiding this comment