Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bumping bat-publisher to 2.0.18 (Fixes payments related crash) #14457

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 19, 2018

Fixes: #14370

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Additional unit tests to reproduce crash case have been baked in to the bat-publisher module

For this branch, it should be tested that a contribution can process via LEDGER_ENVIRONMENT=staging to ensure there are no regressions.

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++++! 10/10 would accept PR again 😎👌 WOW

@bsclifton bsclifton merged commit 7c0a8b2 into brave:master Jun 19, 2018
bsclifton added a commit that referenced this pull request Jun 19, 2018
Bumping bat-publisher to 2.0.18 (Fixes payments related crash)
@bsclifton bsclifton mentioned this pull request Jun 19, 2018
10 tasks
bsclifton added a commit that referenced this pull request Jun 19, 2018
Bumping bat-publisher to 2.0.18 (Fixes payments related crash)
@bsclifton
Copy link
Member

master 7c0a8b2
0.24.x e8975bb
0.23.x d5767a6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants