This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
better handling of frames on window start #145
Merged
+714
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AppActions.newWindow({ | ||
| location: e.url, | ||
| parentFrameKey: this.props.frame.get('key'), | ||
| parentWindowKey: remote.getCurrentWindow().id | ||
| }, e.options) | ||
| guestInstanceId: guestInstanceId |
There was a problem hiding this comment.
nit: you can do this in the future when name/value match:
guestInstanceId,
|
Looks good, please merge when ready. I'll work on brave/electron now. |
bridiver
force-pushed
the
window-opener-fix
branch
from
0b2e7b5
to
3066492
Compare
bbondy
added a commit
that referenced
this pull request
Jan 13, 2016
better handling of frames on window start
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependent upon brave/muon#1
fixes #109
fixes #98
fixes #97
fixes #57
fixes #49