Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removes shadow #15077

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Removes shadow #15077

merged 1 commit into from
Aug 23, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 22, 2018

Resolves #15073

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  • make sure that you can claim grant

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#15073

Auditors:

Test Plan:
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 👍

@bsclifton bsclifton merged commit 6d1df8b into brave:master Aug 23, 2018
bsclifton added a commit that referenced this pull request Aug 23, 2018
bsclifton added a commit that referenced this pull request Aug 23, 2018
@bsclifton
Copy link
Member

master 6d1df8b
0.24.x 1984d36
0.23.x 59e4f42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants