This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Language merge + Refactoring #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aekeus
commented
May 8, 2016
aekeus
commented
- Download current translations
- Support arbitrary language additions
* Added support for async transfer of language code from main to renderer process
* Added availableLanguage support to about*.html files
* Added language request for about* pages
* Added fr-FR selection choice in menus and about pages
* Added reviewed fr-FR language locale
TODO:
* Determine a method of configuring availableLanguages meta tag in
about*.html files without manually modification.
* Modify preference page to automatically show available languages in selection
…ation * Send language codes to web pages to avoid head.meta.availableLanguage changes * Modified about*.html files to accept language codes and modify head.meta.availableLanguages * Added language labels to en-US/preferences.properties * Added language codes to app/locales.js * Modified General Preferences tab to use passed language list in Select form element * Updated tools/downloadLanguages.js with language constant support * Added all languages which have translations
* Language downloads * Re-factoring * Merge master Merge branch 'master' into language-merge
|
Great, thanks! |
This was referenced May 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.