Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger unconfirmed balance fix #3495

Merged
merged 2 commits into from
Aug 28, 2016
Merged

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Aug 28, 2016

the value was being kept in a cache that was being read, but not written… no longer.

also, fix a small typo in docs/state.md

this is the fix for #3480

auditor: @diracdeltas

the value was being kept in a cache that was being read, but not
written… no longer.
@mrose17 mrose17 added this to the 0.11.6dev milestone Aug 28, 2016
@mrose17 mrose17 self-assigned this Aug 28, 2016
console.log('\nupdatePublisherInfo: ' + JSON.stringify(underscore.omit(publisherInfo, [ '_internal' ])))
data = []
publisherInfo.synopsis.forEach((entry) => {
data.push(underscore.extend(underscore.omit(entry, [ 'faviconURL' ]), { faviconURL: entry.faviconURL && '...' }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the "real" string tends to be a long base64 value. all we really need to know is whether a value is present or not, the "..." serves that purpose... otherwise, you get a lot of scrolling in the console window with very little useful content.

@diracdeltas diracdeltas merged commit 67e7073 into master Aug 28, 2016
@bbondy
Copy link
Member

bbondy commented Aug 28, 2016

@mrose17 btw if you use fix #3480 instead of fix for #3480 it'll auto close the issue when merged.

@mrose17
Copy link
Member Author

mrose17 commented Aug 29, 2016

@bbondy - true. however, i generally prefer not to auto-close an issue unless i created it... this allows the person who actually crated the issue to verify that it's fixed...

@bbondy
Copy link
Member

bbondy commented Aug 29, 2016

@mrose17 please follow the process of closing issues when they are complete on master. Sometimes there are multiple commits and QA has it's own process. It would be too confusing to leave things open for testing and that is not the process we're following for this project. It doesn't scale well. Thanks.

@luixxiul
Copy link
Contributor

@mrose17 please ping me or @alexwykoff in case you need QA ;-)

@mrose17 mrose17 deleted the ledger-unconfirmed-balance-fix branch August 29, 2016 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants