This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Harmonize publisher visits #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeats of a location/tabId pair should result in a `revisitP=true` call to `synopsis.addPublisher` so the `visits` counter is not incremented. auditor: @diracdeltas
| @@ -470,7 +470,8 @@ var updatePublisherInfo = () => { | |||
| var entries = [] | |||
|
|
|||
| underscore.keys(publishers[publisher]).forEach((location) => { | |||
There was a problem hiding this comment.
can just do underscore.each(publishers, ...)
There was a problem hiding this comment.
in this case, no... because in the function i need access to both the key and value, not just the value...
There was a problem hiding this comment.
both key and value are accessible http://underscorejs.org/#each
|
please include a test plan in the commit message |
|
i will add a test plan. i had a brief conversation with @bridiver about this... |
|
the eventStore changes look good to me. Discussed the definition of a visit with @mrose17 and that sounds ok too. @diracdeltas I think you are in a better position than I am to review the ledger code. |
This was referenced Sep 10, 2016
This was referenced Sep 12, 2016
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3830
test plan:
open two windows. in one window, put the payments pane; in the other two tabs on the same publisher but different URLs. observer the visits and duration counts in the first window and then switch back and forth between tabs (waiting one or two minutes between each switch). the visits should stay constant and the duration should increase.