This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Top500 ad insertions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice this won't work too well until we use the custom brave/electron pre-built binaries which includes blocking scripts which do ads on pages
|
@bridiver FYI as well. In practice this won't work too well until we use the custom slashdot.org is a good test site though if you want to see it working. |
| /** | ||
| * Ensures a node replacement div is visible and has a proper zIndex | ||
| */ | ||
| function ensureNodeVisible (node) { |
There was a problem hiding this comment.
We probably want to differentiate between visible on the page and visible in the browser viewport. We don't need the former yet, but we will want it before we start displaying real ads. I put a task in the backlog in asana for it.
This was referenced Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aekeus please review