Commits on Oct 16, 2016

1. Bookmarks and siteUtil hardening …

   - new isMoveAllowed (pulled out from moveSite)
   - added unit test to ensure moveSite can't put an ancestor into a descendant
   - about:bookmarks now calls isMoveAllowed before submitting action
   - about:bookmarks allows folder drag onto bookmark; it gets parent folder ID and puts there
   - fixed folder selection bug when searching on about:bookmarks (selection cleared during search)
   
   Fixes #4766
   
   Auditors: @bbondy
   
   Test Plan:
   1. Open about:bookmarks
   2. Create two folders and also bookmark several items, under Bookmarks Toolbar
   3. Click to select a folder which has bookmarks
   4. Drag one of the folders and drop it on a bookmark
   5. Folder should move into the folder that contains bookmark that was dropped onto
   6. Making sure a folder you created is selected on the left (one that is NOT bookmarks toolbar or other bookmarks), do a search
   7. Validate folder selection is cleared on left, in favor of "All Folders"
   8. Drag one of the search results onto a folder on the left
   9. Validate bookmark was moved

   

   bsclifton committed Oct 16, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 9ee0922
   • Browse repository at this point

   Copy the full SHA

   9ee0922 View commit details

   Browse the repository at this point in the history