Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable save button when no detail present #4875

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4855

Auditors: @bbondy

Test Plan:

  1. Open "about:autofill"
  2. Click "Add Address"
  3. The save button should be disabled
  4. Enter the detail of form, the save button should be enabled
  5. Remove all detail of form, the save button should be disabled
  6. Open "about:autofill"
  7. Click "Add Credit Card"
  8. The save button should be disabled
  9. Enter the detail of form, the save button should be enabled (Name, Card Number)
  10. Remove all detail of form, the save button should be disabled (Name, Card Number)
  11. Open "about:autofill"
  12. Add address entry
  13. Edit the address entry
  14. Remove all detail of form, the save button should be disabled
  15. Open "about:autofill"
  16. Add credit card entry
  17. Edit the credit card entry
  18. Remove all detail of form, the save button should be disabled (Name, Card Number)

fix brave#4855

Auditors: @bbondy

Test Plan:
1. Open "about:autofill"
2. Click "Add Address"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled
5. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Click "Add Credit Card"
3. The save button should be disabled
4. Enter the detail of form, the save button should be enabled (Name, Card Number)
5. Remove all detail of form, the save button should be disabled (Name, Card Number)

1. Open "about:autofill"
2. Add address entry
3. Edit the address entry
4. Remove all detail of form, the save button should be disabled

1. Open "about:autofill"
2. Add credit card entry
3. Edit the credit card entry
4. Remove all detail of form, the save button should be disabled (Name, Card Number)
@darkdh darkdh added this to the 0.12.6dev milestone Oct 17, 2016
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Save button on Autofill modal only when user adds details
5 participants