Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow about pages to reload and clone #4881

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Allow about pages to reload and clone #4881

merged 1 commit into from
Oct 18, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 18, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #2826

Auditors: @bridiver, @bbondy

Test Plan:

  1. Generate any error pages(connection error, cert error, ...)
  2. Clone/Reload should work properly
  3. Go to any about pages
  4. Clone/Reload should work properly

@darkdh darkdh added this to the 0.12.6dev milestone Oct 18, 2016
@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

One bug still remains with this, if you turn your wifi off, and load a website to get the connection error page, then re-enable your wifi. Command+R will never work, but if you press the retry connection button it works.

fix brave#2826

Auditors: @bridiver, @bbondy

Test Plan:
1. Generate any error pages(connection error, cert error, ...)
2. Clone/Reload should work properly (reload the original URL)

1. Go to any about pages
2. Clone/Reload should work properly (reload the original URL)
@darkdh
Copy link
Member Author

darkdh commented Oct 18, 2016

Thanks for pointing it out. The new squash commit will reload the original URL. For connection error page as an example, once you got network available and reload the error page by shortcut(cmd/control + r) or reload button will reload the original page.

@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

++ thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error tab cannot be reloaded or cloned
5 participants