Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Do not use default setting when value is false #4907

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 18, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4903

Auditors: @bbondy

Test Plan:

  1. Turn on/off "Always show the URL bar" in about:preferences#general
  2. The title mode should work as expected

fix brave#4903

Auditors: @bbondy

Test Plan:
1. Turn on/off "Always show the URL bar" in about:preferences#general
2. The title mode should work as expected
@darkdh darkdh added this to the 0.12.6dev milestone Oct 18, 2016
@bsclifton
Copy link
Member

++ (and my bad on introducing this- doh)

@bbondy
Copy link
Member

bbondy commented Oct 18, 2016

++ thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSetting() should return the correct vale
5 participants