This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
default browser check should run only on release build #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 19, 2016
| getSetting(settings.CHECK_DEFAULT_ON_STARTUP) | ||
| getSetting(settings.CHECK_DEFAULT_ON_STARTUP) && | ||
| process.env.NODE_ENV !== 'development' && | ||
| process.env.NODE_ENV !== 'test' |
There was a problem hiding this comment.
this looks good, but I think you probably want to add an option to override this check so we can test this without triggering it on every test. Maybe something like process.env.BRAVE_FORCE_CHECK_DEFAULT_ON_STARTUP which would run it regardless of the NODE_ENV or other settings
There was a problem hiding this comment.
+1 on @bridiver's recommendation 😄
BRAVE_IS_DEFAULT_BROWSER for test purpose fix brave#4958 Auditors: @bridiver, @bbondy Test Plan: 1. Make sure there is no session data 2. npm run start/test should not popup the check default browser modal and overrides brave as default browser. 3. BRAVE_IS_DEFAULT_BROWSER=true npm run start/test should not popup the check default browser modal and overrides brave as default browser. 4. BRAVE_IS_DEFAULT_BROWSER=false npm run start/test should popup the check default browser modal and overrides brave not be default browser.
This was referenced Oct 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #4958
Auditors: @bridiver, @bbondy
Test Plan:
and overrides brave as default browser.
and overrides brave as default browser.
and overrides brave not be default browser.