Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Properly display about:newtab when session is null #5411

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Properly display about:newtab when session is null #5411

merged 1 commit into from
Nov 4, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Properly display about:newtab when session is null

Fixes #5379

Auditors: @cezaraugusto

cc: @bbondy, since this does fix the webdriver tests for about:newpage :D

Automated Test Plan (if tests are available for the platform):

  1. Open two consoles, both open to the source
  2. In first one, run npm run watch-test
  3. In other, run `npm run test -- --grep="about:newtab"
  4. Watch the tests pass 😄

Manual Test Plan (Windows)

  1. Move your session folder out of the way (%appdata%\brave)
  2. Launch Brave
  3. It should start with about:newtab. Confirm page loads and is showing a picture

Fixes #5379

Auditors: @cezaraugusto

cc: @bbondy, since this does fix the webdriver tests for about:newpage :D
Test Plan:
@cezaraugusto
Copy link
Contributor

++!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser opens to empty page on first launch
3 participants