This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
isResourceEnabled for private tab #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#5376 Auditors: @bbondy, @bridiver Test Plan: 1. Go to slashdot.org in regular tab 2. Toggle ad control to see the effect 3. Go to slashdot.org in private tab 4. Tab in step 3 should inherit the state of step1 5. Toggle ad control to see the effect 6. Action in private tab will not affect regular tab
|
++ |
This was referenced Nov 10, 2016
|
This did not work for me on OS X. The private tab's shield settings appeared to be correct, but the banner ad did not display.
When I toggle the setting back to Block ads then Allow Ads, the banner ad does display. |
luixxiul
added
the
needs-info
|
It seems like after toggling back from block to allow and the private tab opened afterward will be normal. Please open a new issue assigned to me. |
luixxiul
removed
the
needs-info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #5376
Auditors: @bbondy, @bridiver
Test Plan: