Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

new Brave button hover states #5544

Merged
merged 1 commit into from
Nov 13, 2016
Merged

new Brave button hover states #5544

merged 1 commit into from
Nov 13, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 10, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5528

Test Plan:

Hover over the Brave lion in the top right corner and make sure it looks like the GIF below.

@bradleyrichter this is what it looks like now. is this right?

lion

@jkup jkup added the design A design change, especially one which needs input from the design team. label Nov 10, 2016
@jkup jkup added this to the 0.12.9dev milestone Nov 10, 2016
@bbondy
Copy link
Member

bbondy commented Nov 11, 2016

Assuming this doesn't cause a problem without it on 0.12.9 I'm moving this to 0.12.10.
@bradleyrichter this is waiting on your feedback pls.

@bbondy bbondy modified the milestones: 0.12.10 release , 0.12.9dev Nov 11, 2016
@bradleyrichter
Copy link
Contributor

I think this is missing the new images I committed yesterday? And the grey effect should be removed.

On Nov 11, 2016, at 6:40 AM, Brian R. Bondy notifications@github.com wrote:

Assuming this doesn't cause a problem without it on 0.12.9 I'm moving this to 0.12.10.
@bradleyrichter this is waiting on your feedback pls.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@bradleyrichter
Copy link
Contributor

New pngs Commit number: 881b722

On Nov 11, 2016, at 6:40 AM, Brian R. Bondy notifications@github.com wrote:

Assuming this doesn't cause a problem without it on 0.12.9 I'm moving this to 0.12.10.
@bradleyrichter this is waiting on your feedback pls.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@bbondy
Copy link
Member

bbondy commented Nov 11, 2016

This needs rebasing pls

@jkup
Copy link
Contributor Author

jkup commented Nov 12, 2016

@bbondy rebased!

@bradleyrichter I see, I started on this ticket without knowing you needed to add some more assets. Is it looking right now? (see GIF above)

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 12, 2016

@jkup It looks correct but now we can remove the dark filter in the CSS.

Let's get it in master and then I can work with the hover state image if more visual change is needed.

@bsclifton
Copy link
Member

I like it! 🦁

@jkup
Copy link
Contributor Author

jkup commented Nov 13, 2016

@bradleyrichter @bsclifton I removed the dark filter but now I can hardly tell the difference between the two images. I updated the GIF in the description. Should we just go ahead and ship for now?

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Nov 13, 2016

@jkup perfect. Now I can modify the hover image and get it working perfectly through the magic of pixels. ; )

I'll merge it into master and I'll hot-fix the PNG file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants