Auto complete for the custom bookmark titles in the address bar #6111
Conversation
Resolves brave#6104 Auditors: @bsclifton, @aekeus @bradleyrichter Test Plan: - Save bookmark with a custom title - Search in address bar for a custom title - You should see a bookmark with a custom title in bookmarks section
|
Current implementation of the suggestion window:
As you can see now you have a custom title first |
|
Reviewer note: this PR can be closed if we remove customTitle (which I believe we should do). See note in #6108 (comment) |
|
@bsclifton should we then close this issue then? I can start working on removing customTitle, but I am not sure under which issue is this stated. #5738 or #6108 or both 😃 |
|
@NejcZdovc that would be great! 😄 I'll go ahead and close Removing customTitle, per the discussion linked above, should fix: I'm not sure if #5738 is affected; this seems like a different situation. There are likely other issues which have this same root cause. I'll create a new issue for removing customTitle where we can track them all |
|
@bsclifton great, sounds like a plan. You can assign this issue to me. |
git rebase -ito squash commits (if needed).Resolves #6104
Auditors
@bsclifton, @aekeus, @bradleyrichter
Test Plan