Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

default settings should be last resort #6171

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Dec 13, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #6169

Auditors: @bsclifton, @bbondy

@darkdh darkdh added this to the 0.13.0 milestone Dec 13, 2016
@bsclifton
Copy link
Member

@darkdh could you add a test for this (so we don't accidentally regress in the future)?

Should be easy enough to add here: 😄
https://github.com/brave/browser-laptop/blob/master/test/unit/settingsTest.js

@darkdh
Copy link
Member Author

darkdh commented Dec 13, 2016

will do

@darkdh
Copy link
Member Author

darkdh commented Dec 13, 2016

test added in 8df802d

@bbondy
Copy link
Member

bbondy commented Dec 13, 2016

Thanks!

@bbondy bbondy merged commit 1776e15 into brave:chromium54 Dec 13, 2016
@bsclifton
Copy link
Member

Great job @darkdh, thanks! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants