Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removed obsolete classes from buttons in preferences.js #6388

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Removed obsolete classes from buttons in preferences.js #6388

merged 1 commit into from
Dec 22, 2016

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 22, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

".wideButton" was removed from addfunds, copyButton, advancedSettings as their width is specified exclusively

Auditors: @bsclifton

Test Plan:

  1. Open about:preferences#payments
  2. Make sure the width of "Add funds..." and "Advanced Settings..." button is not affected with the change
  3. Click "Advanced Settings..."
  4. Click "Backup your wallet"
  5. Make sure the width of two "Copy" buttons is not affected with the change

".wideButton" was removed from addfunds, copyButton, advancedSettings

Auditors: @bsclifton

Test Plan:
1. Open about:preferences#payments
2. Make sure the width of "Add funds..." and "Advanced Settings..." button is not affected with the change
3. Click "Advanced Settings..."
4. Click "Backup your wallet"
5. Make sure the width of two "Copy" buttons is not affected with the change
@luixxiul luixxiul added feature/rewards polish Nice to have — usually related to front-end/visual tasks. release-notes/exclude labels Dec 22, 2016
@luixxiul luixxiul self-assigned this Dec 22, 2016
@luixxiul
Copy link
Contributor Author

obviously .wideButton is not a popular className; after this commit is merged it will be only two buttons on .bookmarkHanger that the className is added to.

@luixxiul luixxiul removed their assignment Dec 22, 2016
@bsclifton bsclifton self-requested a review December 22, 2016 22:52
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 22, 2016
@bsclifton
Copy link
Member

LGTM 👍

@bsclifton bsclifton merged commit 93b7c31 into brave:master Dec 22, 2016
@luixxiul luixxiul deleted the remove-buttons-obsolete-classes branch December 23, 2016 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants