Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger recovery error if fields are not set #6455

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Dec 30, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #6447

Auditors @cezaraugusto @bsclifton

This just adds default blank values for the first and second key so if the user clicks recover with either or both unset it won't cause a JavaScript error (just a ledger recovery failed error!)

Test Plan:

  1. Go to Preferences > Payments
  2. Click on Advanced Settings
  3. Click Recover Your Wallet
  4. Click Recover (with the fields blank)
  5. Make sure there is no error in the console and that you do see the recovery failed screen.

screen shot 2016-12-29 at 8 13 04 pm

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants