This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Added open tab setting #6958
Closed
Added open tab setting #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
feature/#6907-new-tab
branch
from
0dafc13
to
54c1b38
Compare
Closed
Resolves brave#6907 Auditors: @bradleyrichter @bsclifton Test Plan: - set desired option in tab settings - new tab should be opened according to this settings
NejcZdovc
force-pushed
the
feature/#6907-new-tab
branch
from
54c1b38
to
80d8887
Compare
|
waiting for #6971 to be resolved |
|
@bradleyrichter should I close this PR? |
|
yes, for now. tx. |
|
Closing based on #6907 (comment) |
|
@NejcZdovc even though the code here isn't used, thanks for troubleshooting and sticking with this issue (along with @bridiver and @bbondy) to completion 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #6907
Auditors
@bradleyrichter @bsclifton
Test Plan