Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Improve wallet recovery algorithm #7289

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Improve wallet recovery algorithm #7289

merged 2 commits into from
Feb 16, 2017

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Feb 16, 2017 •
edited by bsclifton
Loading

Test Plan

  1. about:preferences#payments, 'Advanced Settings..., 'Backup your Wallet', ' Save recovery file...', save as brave_wallet_recovery.txt`
  2. get a vanilla browser install and turn on the ledger -- this creates a new wallet (with a new wallet address)
  3. about:preferences#payments, 'Advanced Settings..., 'Recovery your Wallet', ' Import recovery keys', select brave_wallet_recovery.txt`
  4. verify that value of properties.wallet.address does not change after step 3

Description

Fixes #7288

@mrose17 mrose17 added this to the 0.13.5 milestone Feb 16, 2017
@mrose17 mrose17 self-assigned this Feb 16, 2017
bsclifton
bsclifton approved these changes Feb 16, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out; worked as expected. LGTM 😄

@bsclifton bsclifton merged commit e0fc770 into master Feb 16, 2017
@bsclifton bsclifton deleted the issue-7288 branch February 16, 2017 20:47
@mrose17 mrose17 mentioned this pull request Feb 16, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@mrose17 mrose17

Labels
feature/rewards
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mrose17 @bsclifton