Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add support for 100 tabs #7695

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Add support for 100 tabs #7695

merged 1 commit into from
Mar 14, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 14, 2017

Test Plan:

  • Clear session
  • Go to preferences->tabs
  • Default should be 20
  • Opt for 100 tabs
  • Open 100 tabs
  • Tabs should resize accordingly

Description

Fix #6692

Note: this PR also sets default number of tabs per page to 20

Auditors: @bbondy, @bsclifton

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 14, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 14, 2017
@bsclifton
Copy link
Member

Had to share this- here's 100 tabs open on my 27" Thunderbolt monitor 😄
screen shot 2017-03-14 at 1 04 02 am

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, everything works great 😄 As shown in the screenshot, I actually had over 100 tabs open. I got the RAM usage up to 11 GB!! (who knows how many videos were playing at the same time)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants