-
Notifications
You must be signed in to change notification settings - Fork 974
use write.writeImportant for session store #8593
Conversation
a765517
to
7883a67
Compare
7883a67
to
40abc0c
Compare
++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
} | ||
return p | ||
} | ||
|
||
/** | ||
* Clears all session cache. | ||
* @return a promise that always resolves (called on app shutdon so must always) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated; doesn't return a promise anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that's true for several of these now
for (let partition in registeredSessions) { | ||
let ses = registeredSessions[partition] | ||
p = p.then(promisify(ses.clearCache.bind(ses)).catch(() => {})) | ||
setImmediate(ses.clearCache.bind(ses)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are docs on the Muon side, I think it would be helpful to put a link to the docs as a comment; ex:
https://github.com/brave/muon/blob/master/docs/api/session.md#sesclearcachecallback
(and if needed, update the docs)
fix #7876
git rebase -i
to squash commits (if needed).Test Plan:
quit/restart behavior when updating